This repository has been archived by the owner on Dec 3, 2021. It is now read-only.
Add spelling check to CI #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also corrected all the spelling issues in the current labs. Signed-off-by: Stephen Kiely <stephenkiely87@gmail.com>
Signed-off-by: Stephen Kiely <stephenkiely87@gmail.com>
…ing a different aspell dictionary. Signed-off-by: Stephen Kiely <stephenkiely87@gmail.com>
Signed-off-by: Stephen Kiely <stephenkiely87@gmail.com>
Signed-off-by: Stephen Kiely <stephenkiely87@gmail.com>
Signed-off-by: Stephen Kiely <stephenkiely87@gmail.com>
|
@smk4664 As usual, this is really great work, and I'm sorry it took so long to get this integrated. I'll take care of the merge conflicts and merge this so we can make use of it. Thanks! |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High-Level Overview of this Curriculum Contribution:
This Pull request adds a spelling checker to the CI pipeline. After this change is merged, future spelling issues will need to be corrected before the pipeline will allow merging. This also provides a dictionary file .aspell.en.pws to add industry words that are not recognized by the Aspell en dictionary. The checker will ignore text in markdown and html code blocks, text in html pre blocks, and html tags. The Aspell library was chosen for ease of adding dictionary items and multiple language support (though not currently built in the script).
Which issue(s) this PR fixes:
Fixes #201 201
Is This Ready to Review?:
Yes