Remove poltergeist support

nruth · Jul 14, 2022 · 299afb2 · 299afb2
1 parent 77761b9
commit 299afb2
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 92 deletions.
diff --git a/Changelog.md b/Changelog.md
@@ -1,3 +1,9 @@
+# 6.0.0
+
+## Breaking change: Poltergeist removed
+
+It's been obsolete for a while now. If you still need it, you can copy the driver / registration into your app's test code.
+
 # 5.0.1
 
 ## Gem development dependencies

diff --git a/Gemfile b/Gemfile
@@ -7,7 +7,6 @@ gem 'rake' # for releases
 
 group :test do
   gem 'rspec', '~> 3.0'
-  gem 'poltergeist'
   gem 'sinatra'
   gem 'selenium-webdriver'
   gem 'webdrivers', '~> 4.0' # chromedriver installer

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -18,7 +18,6 @@ GEM
       regexp_parser (~> 1.5)
       xpath (~> 3.2)
     childprocess (3.0.0)
-    cliver (0.3.2)
     diff-lcs (1.3)
     mini_mime (1.0.2)
     mini_portile2 (2.5.1)
@@ -27,10 +26,6 @@ GEM
     nokogiri (1.11.4)
       mini_portile2 (~> 2.5.0)
       racc (~> 1.4)
-    poltergeist (1.18.1)
-      capybara (>= 2.1, < 4)
-      cliver (~> 0.3.1)
-      websocket-driver (>= 0.2.0)
     public_suffix (4.0.6)
     racc (1.5.2)
     rack (2.2.3)
@@ -68,17 +63,13 @@ GEM
       nokogiri (~> 1.6)
       rubyzip (>= 1.3.0)
       selenium-webdriver (>= 3.0, < 4.0)
-    websocket-driver (0.7.1)
-      websocket-extensions (>= 0.1.0)
-    websocket-extensions (0.1.5)
     xpath (3.2.0)
       nokogiri (~> 1.8)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  poltergeist
   rake
   rspec (~> 3.0)
   selenium-webdriver
@@ -87,4 +78,4 @@ DEPENDENCIES
   webdrivers (~> 4.0)
 
 BUNDLED WITH
-   2.0.2
+   2.2.16
diff --git a/README.md b/README.md
@@ -4,7 +4,7 @@
 
 Some helpers for poking around at your Capybara driven browser's cookies in integration tests.
 
-Provides drivers for rack-test, [selenium-webdriver](https://rubygems.org/gems/selenium-webdriver), and [Poltergeist](https://github.com/teampoltergeist/poltergeist) (PhantomJS).
+Provides drivers for rack-test and [selenium-webdriver](https://rubygems.org/gems/selenium-webdriver).
 
 You can add new drivers to  your application by implementing an adapter class and calling ShowMeTheCookies.register_adapter in your test code (e.g. a spec/support file). But in that case you might prefer to skip this gem and use your driver's api directly.
 

diff --git a/lib/show_me_the_cookies.rb b/lib/show_me_the_cookies.rb
@@ -1,6 +1,5 @@
 module ShowMeTheCookies
   require 'show_me_the_cookies/adapters/rack_test'
-  require 'show_me_the_cookies/adapters/poltergeist'
   require 'show_me_the_cookies/adapters/selenium'
   require 'show_me_the_cookies/adapters/selenium_chrome'
 
@@ -22,7 +21,6 @@ def register_adapter(driver, adapter)
   register_adapter(:selenium_chrome, ShowMeTheCookies::SeleniumChrome)
   register_adapter(:selenium_chrome_headless, ShowMeTheCookies::SeleniumChrome)
   register_adapter(:rack_test, ShowMeTheCookies::RackTest)
-  register_adapter(:poltergeist, ShowMeTheCookies::Poltergeist)
 
   # puts a string summary of the cookie
   def show_me_the_cookie(cookie_name)

diff --git a/lib/show_me_the_cookies/adapters/poltergeist.rb b/lib/show_me_the_cookies/adapters/poltergeist.rb
diff --git a/lib/show_me_the_cookies/version.rb b/lib/show_me_the_cookies/version.rb
@@ -1,5 +1,5 @@
 # change gem version here then use bundler's rake tasks to make a new release
 # follow semantic versioning http://guides.rubygems.org/patterns/#semantic-versioning
 module ShowMeTheCookies
-  VERSION = '5.0.1'
+  VERSION = '6.0.0'
 end
diff --git a/spec/drivers/poltergeist_spec.rb b/spec/drivers/poltergeist_spec.rb