Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add missing "fallback-sha" to list of arguments #169

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

kumboleijo
Copy link
Contributor

@kumboleijo kumboleijo commented Sep 24, 2024

Description

The fallback-sha is listed as a valid input on the github composite action but never passed (#158) to the javascript running behind the scenes. This PR extracts the fallback-sha from the github inputs and passes it to the list of arguments.

Linked Issues:

Important

This PR is most likely to be ignored if PR #163 is being merged.

I tested this update in a private repo and it seems to be working just fine.
image

@mandarini mandarini enabled auto-merge (squash) September 27, 2024 14:26
@mandarini mandarini disabled auto-merge September 27, 2024 14:26
@mandarini mandarini enabled auto-merge (squash) September 27, 2024 14:27
@mandarini mandarini merged commit be2a366 into nrwl:main Sep 27, 2024
7 checks passed
@mandarini mandarini linked an issue Sep 27, 2024 that may be closed by this pull request
@mandarini mandarini mentioned this pull request Sep 27, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fallback-sha is ignored
2 participants