fix(core): ensure preinstall is only run once on repo, not on every d…

…eps change
nrwl · Aug 17, 2023 · 4cbe93b · 4cbe93b
1 parent 5240896
commit 4cbe93b
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/packages/devkit/src/tasks/install-packages-task.ts b/packages/devkit/src/tasks/install-packages-task.ts
@@ -4,6 +4,7 @@ import { requireNx } from '../../nx';
 
 import type { Tree } from 'nx/src/generators/tree';
 import type { PackageManager } from 'nx/src/utils/package-manager';
+import { existsSync } from 'fs';
 const { detectPackageManager, getPackageManagerCommand, joinPathFragments } =
   requireNx();
 
@@ -42,7 +43,9 @@ export function installPackagesTask(
       cwd: join(tree.root, cwd),
       stdio: process.env.NX_GENERATE_QUIET === 'true' ? 'ignore' : 'inherit',
     };
-    if (pmc.preInstall) {
+    // only run preinstall if install hasn't been run yet
+    // this only happens during CNW when preset is adding its dependencies
+    if (pmc.preInstall && !existsSync(joinPathFragments(cwd, 'node_modules'))) {
       execSync(pmc.preInstall, execSyncOptions);
     }
     execSync(pmc.install, execSyncOptions);