chore(nx-dev): switch e2e to playwright #18629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barbados-clemens
requested review from
FrozenPandaz,
vsavkin,
a team,
StalkAltan and
rarmatei
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
barbados-clemens
added
type: docs
scope: testing tools
barbados-clemens
force-pushed
the
chore/docs-playwright
branch
from
968b98c to
aa5e7c2
Compare
Comment on lines
-25
to
-27
| "outputs": ["{options.outputPath}"], | ||
| "outputs": ["{workspaceRoot}/dist/nx-dev/nx-dev/public"], | ||
| "options": { | ||
| "outputPath": "dist/nx-dev/nx-dev/public", |
There was a problem hiding this comment.
ran nx repair bc nx wasn't happy with existing outputs? unsure if this is right? cc @FrozenPandaz
barbados-clemens
force-pushed
the
chore/docs-playwright
branch
from
aa5e7c2 to
c9f9d30
Compare
barbados-clemens
force-pushed
the
chore/docs-playwright
branch
from
c9f9d30 to
d6084bb
Compare
barbados-clemens
force-pushed
the
chore/docs-playwright
branch
from
d6084bb to
c9849ab
Compare
barbados-clemens
force-pushed
the
chore/docs-playwright
branch
from
c9849ab to
566f3ca
Compare
barbados-clemens
force-pushed
the
chore/docs-playwright
branch
from
566f3ca to
7e893b2
Compare
barbados-clemens
force-pushed
the
chore/docs-playwright
branch
from
7e893b2 to
cf81ecc
Compare
barbados-clemens
force-pushed
the
chore/docs-playwright
branch
from
cf81ecc to
c89b00a
Compare
AgentEnder
approved these changes
Aug 22, 2023
isaacplmann
requested changes
Aug 22, 2023
barbados-clemens
force-pushed
the
chore/docs-playwright
branch
from
c89b00a to
46203e9
Compare
FrozenPandaz
approved these changes
Aug 23, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Nx repo doesn't have a playwright project to dogfood the plugin for
Expected Behavior
nx-dev-e2e project uses playwright
also fixed issue with some pages having multiple h1 tags causing playwright to fail.
Related Issue(s)
Note: playwright be default is set to run against chromium, firefox, and webkit. We can configure this to only run on 1 browser if so desired, but left running against multiple for now. approx run time in CI is 12 mins for firefox, chrome, webkit
Fixes #