Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(js): fix typescript analysis for imports in objects in arrays #19862

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

FrozenPandaz
Copy link
Collaborator

@FrozenPandaz FrozenPandaz commented Oct 25, 2023

Current Behavior

When imports are in an object in an array (popular when defining routes), the imports were determined to be Static even though they should be Dynamic:

      const routes = [
        {},
        {
            lazy: () => import('dynamic-import-lazy-route')
        }
      ]

Expected Behavior

When imports are in an object in an array (popular when defining routes), the imports are determined to be Dynamic:

      const routes = [
        {},
        {
            lazy: () => import('dynamic-import-lazy-route')
        }
      ]

image

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested review from a team as code owners October 25, 2023 20:23
@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 9:43pm

@FrozenPandaz FrozenPandaz merged commit bf97dbb into nrwl:master Oct 26, 2023
Copy link

github-actions bot commented Nov 1, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants