Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(angular): extract remotes from manifest correctly #19880 #19894

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Oct 27, 2023

Current Behavior

When extracting remotes from manifest, we use Object.keys, which returns the array. However, we push this full array into another array, instead of spreading it.

Expected Behavior

Spread the Object.keys array to add each remote extracted individually

Related Issue(s)

Fixes #19880

@Coly010 Coly010 requested a review from jaysoo as a code owner October 27, 2023 10:02
@Coly010 Coly010 self-assigned this Oct 27, 2023
@Coly010 Coly010 requested a review from ndcunningham October 27, 2023 10:02
@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Oct 27, 2023 10:03am

@Coly010 Coly010 changed the title fix(angular): extract remotes from manifest correctly fix(angular): extract remotes from manifest correctly #19880 Oct 27, 2023
Copy link

github-actions bot commented Nov 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Host app fails to serve remote application when we execute nx serve host
3 participants