Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(js): add swc cli options --strip-leading-paths #22193

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

hongxuWei
Copy link
Contributor

@hongxuWei hongxuWei commented Mar 7, 2024

Current Behavior

can't pass the cli options --strip-leading-paths to swc executor

Expected Behavior

add a config stripLeadingPaths pass through to cli options

Related Issue(s)

Fixes #22361

@hongxuWei hongxuWei requested review from a team as code owners March 7, 2024 02:41
@hongxuWei hongxuWei requested review from jaysoo and leosvelperez March 7, 2024 02:41
Copy link

vercel bot commented Mar 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Apr 10, 2024 9:46pm

@hongxuWei
Copy link
Contributor Author

@jaysoo @leosvelperez
Please check this pull request~

@jaysoo
Copy link
Member

jaysoo commented Apr 5, 2024

@hongxuWei Thanks, the @swc/cli needs to be updated as well to support the option. Once the CI is green it'll be merged.

@jaysoo
Copy link
Member

jaysoo commented Apr 5, 2024

The new @swc/cli version is causing dist to generate differently. Need to debug and fix.

@jaysoo jaysoo merged commit f59ed58 into nrwl:master Apr 11, 2024
6 checks passed
FrozenPandaz added a commit to FrozenPandaz/nx that referenced this pull request Apr 15, 2024
FrozenPandaz added a commit to FrozenPandaz/nx that referenced this pull request Apr 15, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

swc cli options --strip-leading-paths
2 participants