Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(node): Add output path to setup docker #26365

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

ndcunningham
Copy link
Contributor

@ndcunningham ndcunningham commented Jun 4, 2024

This PR updates how we generate a DockerFile for inferred and non inferred projects.

Now you need to provide a output path.

@ndcunningham ndcunningham added the scope: node Issues related to Node, Express, NestJS support for Nx label Jun 4, 2024
@ndcunningham ndcunningham self-assigned this Jun 4, 2024
@ndcunningham ndcunningham requested review from a team as code owners June 4, 2024 19:38
@ndcunningham ndcunningham requested a review from jaysoo June 4, 2024 19:39
Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jun 5, 2024 5:42pm

This helps when we are generating the docker file for inferred and non inferred projects

update
@ndcunningham ndcunningham merged commit 9eebe49 into master Jun 6, 2024
6 checks passed
@ndcunningham ndcunningham deleted the feat/node-setup-docker-generator branch June 6, 2024 16:42
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
scope: node Issues related to Node, Express, NestJS support for Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants