fix(js): generate nx release config correctly for js libraries in new ts setup and set tags #28218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2a3550e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-28218-5048fd1 my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-28218-5048fd1
To request a new release for this pull request, mention someone from the Nx team or the |
leosvelperez
force-pushed
the
js/fix-library-config-in-package-json
branch
from
5048fd1 to
d4ec1f7
Compare
leosvelperez
force-pushed
the
js/fix-library-config-in-package-json
branch
from
d4ec1f7 to
cc10cac
Compare
… ts setup and set tags
leosvelperez
force-pushed
the
js/fix-library-config-in-package-json
branch
from
cc10cac to
2a3550e
Compare
JamesHenry
approved these changes
Oct 2, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When setting the Nx configuration for a JS library in the
package.jsonfile, the provided tags is not set and the relevantnx releaseconfiguration innx.jsonis not set either.Expected Behavior
When setting the Nx configuration for a JS library in the
package.jsonfile, the provided tags should be set and the relevantnx releaseconfiguration innx.jsonshould be configured.Related Issue(s)
Fixes #