Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(js): throw an error when generating a publishable lib with --bundler=none #28221

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Oct 1, 2024

Current Behavior

Generating a JS publishable library with --bundler=none results in the generator silently switching the bundler to tsc and generating a build target.

Expected Behavior

Trying to generate a JS publishable library with --bundler=none should throw an error.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Oct 1, 2024
@leosvelperez leosvelperez requested review from a team as code owners October 1, 2024 13:11
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 1:13pm

@leosvelperez leosvelperez merged commit 942f6fc into master Oct 2, 2024
6 checks passed
@leosvelperez leosvelperez deleted the js/fix-publishable-bundler branch October 2, 2024 12:24
Copy link

github-actions bot commented Oct 8, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants