Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(core): support reading projects under new pnpm workspaces entry + skip writing empty nx property to pacakge.json for non-root projects #29707

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jan 21, 2025

This PR is a prerequisite to removing nx property from package.json files in the new TS setup. It fixes two issues:

  1. We always write nx property in package.json even if it is empty. This should be done for root projects.
  2. Adding an entry to pnpm-workspace.yaml is not picked up because readProjectConfiguration only reads the file from disk, not from virtual Tree

This is the next PR to remove the property: #29705

…+ skip writing empty nx property to pacakge.json for non-root projects
@jaysoo jaysoo requested a review from a team as a code owner January 21, 2025 21:21
@jaysoo jaysoo requested a review from Cammisuli January 21, 2025 21:21
Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 9:22pm

Copy link

nx-cloud bot commented Jan 21, 2025

View your CI Pipeline Execution ↗ for commit 251e95d.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 35m 59s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 4s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx format:check --base=104f0... ✅ Succeeded 23s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 22s View ↗
nx documentation --no-dte ✅ Succeeded 43s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-21 22:02:14 UTC

@FrozenPandaz FrozenPandaz merged commit cf206c3 into master Jan 21, 2025
6 checks passed
@FrozenPandaz FrozenPandaz deleted the fix/minimal-workspaces branch January 21, 2025 22:11
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants