issue_896: Last change before the long weekend. Hoping these changes …

…will make github actions happy.
nsacyber · Feb 14, 2025 · 6b38fa8 · 6b38fa8
1 parent 828afe2
commit 6b38fa8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/...src/main/java/hirs/attestationca/persist/validation/CertificateAttributeScvValidator.java b/...src/main/java/hirs/attestationca/persist/validation/CertificateAttributeScvValidator.java
@@ -265,12 +265,10 @@ public static AppraisalStatus validatePlatformCredentialAttributesV2p0(
             List<ComponentIdentifierV2> allV2PcComponents
                     = new ArrayList<>(platformCredential.getComponentIdentifiersV2());
 
-            if (componentInfos == null) {
-                log.error("The device's reported list of components is null.");
-                passesValidation = false;
-            } else if (componentInfos.size() != allV2PcComponents.size()) {
+            if (componentInfos.size() != allV2PcComponents.size()) {
                 log.error(
-                        "The device's reported list of components' sizes (size of {}) do not match the size (size of {}) "
+                        "The device's reported list of components' sizes (size of {}) " +
+                                "do not match the size (size of {}) "
                                 + "of the platform credential's version 2 component identifiers.",
                         componentInfos.size(), allV2PcComponents.size());
 

diff --git a/...c/test/java/hirs/attestationca/persist/validation/SupplyChainCredentialValidatorTest.java b/...c/test/java/hirs/attestationca/persist/validation/SupplyChainCredentialValidatorTest.java
@@ -1306,8 +1306,8 @@ public final void testValPCAttributesV2p0WithComponentsPassPlatformSerialWithSys
     }
 
     /**
-     * Second test that tests that TPM 2.0 Platform Credentials validate correctly against the device info report
-     * when there are components present, and when the PlatformSerial field holds the system's
+     * Second test that tests that TPM 2.0 Platform Credentials validate correctly against the device info
+     * report when there are components present, and when the PlatformSerial field holds the system's
      * serial number instead of the baseboard serial number.
      *
      * @throws IOException        if unable to set up DeviceInfoReport from resource file