Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CLI output can be unclear #42

Closed
nshki opened this issue Jan 5, 2024 · 0 comments · Fixed by #44
Closed

CLI output can be unclear #42

nshki opened this issue Jan 5, 2024 · 0 comments · Fixed by #44

Comments

@nshki
Copy link
Owner

nshki commented Jan 5, 2024

Formalizing this into an issue from @G-Rath's comment here.

It might be worth reviewing the output later at some point:

❯ bundle exec rake dev:annotate

Chusaku has finished running.
Model files unchanged.

❯ bundle exec rake dev:annotate
Nothing to annotate.
Model files unchanged.

Specifically, removing that leading newline, and changing the "Nothing to annotate" to "Controller files unchanged" or something similar to make it clearer what it's referring to.
@G-Rath G-Rath mentioned this issue Jan 5, 2024
Merged
@nshki nshki closed this as completed in #44 Jan 5, 2024
nshki pushed a commit that referenced this issue Jan 5, 2024
@G-Rath
fix: improve cli output (#44)
82d9e22 
Before:

```
❯ bundle exec rake dev:annotate

Chusaku has finished running.
Model files unchanged.

❯ bundle exec rake dev:annotate
Nothing to annotate.
Model files unchanged.
```

After:

```
❯ bundle exec rake dev:annotate
Chusaku has finished running.
Model files unchanged.

❯ bundle exec rake dev:annotate
Controller files unchanged.
Model files unchanged.
```

I've also preserved the newline before the final output line if
`--verbose` is passed.

Resolves #42
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improve cli output
1 participant
@nshki