Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Semicolon #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Semicolon #54

wants to merge 2 commits into from

Conversation

linwaytin
Copy link

@linwaytin linwaytin commented Sep 26, 2020

I make a workaround to allow ";" at the end for the issue #53 .
I also change p[i] to p[j] in the split function, which makes the results reasonable.
Thank you.

This gives the correct split function.
@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #54 into master will increase coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   47.25%   47.27%   +0.01%     
==========================================
  Files          10       10              
  Lines         328      330       +2     
==========================================
+ Hits          155      156       +1     
- Misses        173      174       +1     
Impacted Files Coverage Δ
src/mexpr.jl 65.09% <75.00%> (-0.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7be4dbd...5bf065f. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.002%) to 46.254% when pulling 5bf065f on linwaytin:semicolon into 7be4dbd on nsmith5:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.002%) to 46.254% when pulling 5bf065f on linwaytin:semicolon into 7be4dbd on nsmith5:master.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants