NEO candidate registration via NEP-27 callback #3700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3700 +/- ##
==========================================
- Coverage 83.10% 83.06% -0.04%
==========================================
Files 335 335
Lines 46821 46855 +34
==========================================
+ Hits 38911 38922 +11
- Misses 6317 6343 +26
+ Partials 1593 1590 -3 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
reviewed
Nov 25, 2024
roman-khimov
force-pushed
the
nep-27-candidate-registration
branch
from
d4d1ff2 to
e80e08d
Compare
AnnaShaleva
reviewed
Dec 23, 2024
AnnaShaleva
reviewed
Dec 23, 2024
This was referenced Dec 23, 2024
Ref. #3775, this PR is only about contract-related changes. |
Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
nep-27-candidate-registration
branch
from
e80e08d to
f0457ab
Compare
AnnaShaleva
approved these changes
Dec 25, 2024
There was a problem hiding this comment.
We may merge it right now, or may wait for neo-project/neo#3643, @roman-khimov, it's up to you.
Solves two problems: * inability to estimate GAS needed for registerCandidate in a regular way because of its very high fee (more than what normal RPC servers allow) * inability to have MaxBlockSystemFee lower than the registration price which is very high on its own (more than practically possible to execute) See neo-project/neo#3552. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Connection succeeds when AIO is running, some more obscure port is less likely to cause this problem. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
nep-27-candidate-registration
branch
from
f0457ab to
38b9b13
Compare
|
neo-project/neo#3643 will require some additional support from manifest generator and it's not yet there. Let's sync with the current state of things and standard can be added later. |
AnnaShaleva
approved these changes
Dec 25, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See neo-project/neo#3552. Depends on neo-project/neo#3597.