Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Increment penalty in case of repeated violation during previous duration #261

Merged
merged 2 commits into from
May 10, 2024

Conversation

vzotova
Copy link
Member

@vzotova vzotova commented May 3, 2024

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:
See #259

Issues fixed/closed:
Fixes #259

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on?
Is there a particular commit/function/section of your PR that requires more attention from reviewers?

@vzotova vzotova self-assigned this May 3, 2024
@vzotova vzotova marked this pull request as ready for review May 3, 2024 21:12
Copy link
Member

@manumonti manumonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👌

Copy link
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

Copy link
Member

@arjunhassard arjunhassard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! One future-proofing comment; at some point it would be useful to add a variable – violationTimeframe or something, which can be tuned so that if there are lots of DKG incompletions within a short timeframe (e.g. 3 hours), the guilty staker is given a reprieve from penalty increments, and only sees their rewards reduced by the default (unless they were already within a penalty period, of course!).

Co-authored-by: Arjun Hassard <arjunhassard@gmail.com>
@cygnusv cygnusv merged commit 449ec47 into nucypher:main May 10, 2024
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

penaltyPercent to scale with each violation
6 participants