Skip to content

Add SetBinaryLog support to DotNetPackSettings #1522

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MikeFarrington
Copy link

  • Added support for SetBinaryLog to DotNetPackSettings
  • Added complementary ResetBinaryLog
  • Fixed minor typo in a related xml summary tag

Binary Logging is supported by dotnet pack, but had not yet been exposed in Nuke via DotNetPackSettings. Since this a trivial change to a tool setting, there is no backing issue (as requested in the contributing guidelines).

I confirm that the pull-request:

  • Follows the contribution guidelines
  • Is based on my own work
  • Is in compliance with my employer

@ITaluone
Copy link
Contributor

Other way round: Needing the DotNet.json not the DotNet.Generated.cs

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants