Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Type stable #77

Merged
merged 10 commits into from
Apr 10, 2023
Merged

Type stable #77

merged 10 commits into from
Apr 10, 2023

Conversation

iintSjds
Copy link
Member

@iintSjds iintSjds commented Apr 6, 2023

  • Fixed type stable problem caused by mesh.shift of uniform meshes.
    Now in getindex the mesh.shift is first converted to a SVector of T rather than of Rational.
  • Added tests to check the return type of getindex.
  • Also merged some changes(change version No. etc.) from master that's not yet updated in dev.
  • And updated some tests with test_throws macro.

@iintSjds iintSjds added the bug Something isn't working label Apr 6, 2023
@iintSjds iintSjds linked an issue Apr 6, 2023 that may be closed by this pull request
@iintSjds iintSjds requested a review from kunyuan April 6, 2023 17:35
@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

Merging #77 (6d69025) into dev (5832c2a) will increase coverage by 0.04%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev      #77      +/-   ##
==========================================
+ Coverage   78.94%   78.99%   +0.04%     
==========================================
  Files          16       16              
  Lines         969      971       +2     
==========================================
+ Hits          765      767       +2     
  Misses        204      204              
Impacted Files Coverage Δ
src/BaseMesh.jl 95.74% <100.00%> (+0.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iintSjds iintSjds merged commit 9c8813e into dev Apr 10, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getindex has type stability problem
4 participants