Fix inconsistency with 1 dof #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #55 +/- ##
==========================================
- Coverage 85.03% 84.97% -0.06%
==========================================
Files 20 16 -4
Lines 1410 1398 -12
==========================================
- Hits 1199 1188 -11
+ Misses 211 210 -1 ☔ View full report in Codecov by Sentry. |
kunyuan
approved these changes
Dec 31, 2023
|
Thank you for fixing this issue! |
iintSjds
approved these changes
Dec 31, 2023
|
Thank you @kunyuan ! It would be great if this could be added to the next patch release |
|
We will be submitting a patch release soon. Thank you once again. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed an issue where if the integrand has one degree of freedom, but is a vector, I would get a type conversion error. I've fixed it by letting broadcasting figure out the size of the integrand and I added an interface test that checks this case. I hope this wouldn't break much code since it looked like the implementation implicitly assumes the integrand returns either a number or vector and not a multidimensional array.