Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Icons for Beyond Compare #5581

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

maxtron95
Copy link
Contributor

Fixes #3025

bcompare-ci
bcompare-sq

@palob palob added the merge label Sep 2, 2020
Copy link
Member

@palob palob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Symbol looks a bit big.
What is the original icon depicting? A car wheel?

@palob
Copy link
Member

palob commented May 22, 2021

This might look less busy w/o the circle on the hexagon.

@palob
Copy link
Member

palob commented Aug 10, 2021

@creepertron95 Will you finish your open PRs? If not, I can step in in the coming weeks.

@maxtron95
Copy link
Contributor Author

maxtron95 commented Aug 10, 2021

@palob I haven't been active in this repo for a while, It's fine for you to step in and clear the PRs.

@mrmeszaros
Copy link
Contributor

@palob Beyond Compare is a diff tool for files and folders. It is developed by Scooter Software, Inc. - hence the logo: a wheel of a scooter with "diff arrows".
I kind of like it, though it does look a bit too big and busy in the center.

bcompare-30x30

Maybe downsized to 24x24? Or would it be too much?

bcompare-24x24

(It's just a quick scale down without realigning)

@palob
Copy link
Member

palob commented Nov 11, 2022

I think it can be 26x26.

@mrmeszaros
Copy link
Contributor

mrmeszaros commented Nov 11, 2022

Ok - in the meantime I already did a 24x24 so here is a comparison:

24x24 26x26
bcompare circle 768 bcompare circle 768 26

The inside of the wheel might need some work (no baseplate/white, lighter grey "screw", wheel inner drop shadow).

@palob
Copy link
Member

palob commented Nov 12, 2022

24 and 26 both work. I prefer the smaller nut. I think there shouldn't be the ring of the baseplate peeking through, so the inner part looks like a hub cap similar to the original icon. Maybe the arrows could drop a shadow over the other wheel parts.
Maybe the tyre part could get some lighter/darker coloured "dents" on the outside, looking like a tyre tread.

@mrmeszaros
Copy link
Contributor

OK, so: smaller nut, no baseline peekthrough, arrow dropshadow ✔️

Fiddling a bit with the outside dents - not sure about how many - I feel like 7 is kinda fine.
I made the tire is made a bit lighter (#333333) and did the dents half and half dark (#1a1a1a) and llight (#4d4d4d) to see which are better.
Though the dents are still not very visible.
Maybe a bigger shape could also help... do You have any ideas?

5 dents 7 dents 9 dents
bcompare circle 384 g5c bcompare circle 384 g7c bcompare circle 384 g9c

Also, I think I'll create a separate PR, since it looks like I'll be able to finish this.

@palob
Copy link
Member

palob commented Nov 17, 2022

Maybe bigger dents, brighter on the upper half, darker on the bottom half.

@mrmeszaros
Copy link
Contributor

mrmeszaros commented Nov 17, 2022

Bigger dents:

Full Light Halfsies Full Dark
bcompare circle 384 d5-ll bcompare circle 384 d5-ld bcompare circle 384 d5-dd

Greys are 10L apart, yet the light seems less contrasty, so for me the full dark works better.

@palob
Copy link
Member

palob commented Nov 17, 2022

How dark are the dark dents? Shouldn't be darker than L20. You're right, full dark is the best, the mix looks a bit busy.

@mrmeszaros
Copy link
Contributor

mrmeszaros commented Nov 22, 2022

Sadly the dark dents are L10. So here are two versions with only L20+ greys:

#555555(L33) / #363330(L20) #474747(L28) / #363330(L20) #333333(L20) / #6b6761(L40)
bcompare circle 384 cb5-dol bcompare circle 384 cb5-dol2 bcompare circle 384 cb5-lod

To me with the L20 restriction the second one works better

Edit:

Added L28/L20 version in the middle

@palob
Copy link
Member

palob commented Nov 22, 2022

How does it look with L28 for the tyre and L20 for the dents?

@palob
Copy link
Member

palob commented Feb 18, 2023

@mrmeszaros Sorry, didn't notice your edit. L33/L26 I think it is.
Blue and red could be a bit brightened up/desaturated.

Copy link
Contributor

@Foggalong Foggalong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am no longer a member of Numix Project so my review is moot (see #5868).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Development

Successfully merging this pull request may close these issues.

Icon for Beyond Compare
4 participants