Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

BUG: validator now handles properties #500

Merged
merged 3 commits into from
Sep 7, 2023
Merged

BUG: validator now handles properties #500

merged 3 commits into from
Sep 7, 2023

Conversation

sdiebolt
Copy link
Contributor

This PR fixes a bug that prevented Validator.source_file_def_line and Validator.source_file_name to return correct values on @property and @functools.cached_property decorated methods.

Similarly to #496, this issue made validate miss inline ignore comments on properties, since the definition line and source file name of properties would be None.

Closes #495.

@sdiebolt sdiebolt mentioned this pull request Aug 30, 2023
Closed
@larsoner
Copy link
Collaborator

larsoner commented Sep 7, 2023

Thanks @sdiebolt !

@larsoner larsoner merged commit 881c0ab into numpy:main Sep 7, 2023
@stefanv stefanv added this to the 1.6.0 milestone Sep 7, 2023
@knutfrode knutfrode mentioned this pull request Oct 4, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@larsoner larsoner larsoner approved these changes

@rossbar rossbar Awaiting requested review from rossbar

Assignees
No one assigned
Labels
type: Bug fix
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

numpydoc ignore inline comment not recognized when using decorators
4 participants
@sdiebolt @larsoner @stefanv @jarrodmillman