Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump versions of Grafana and InfluxDB Helm charts #37

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

adriansuarez
Copy link
Collaborator

@adriansuarez adriansuarez commented Jan 18, 2023

This should address the removal of PodSecurityPolicy from Kubernetes 1.25, since the Grafana Helm charts now conditionalize the creation of the PodSecurityPolicy on the existence of the API resource.

Copy link
Contributor

@sivanov-nuodb sivanov-nuodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sivanov-nuodb
Copy link
Contributor

Should we also bump the K8s version used in the tests to get coverage for this issue?

@adriansuarez
Copy link
Collaborator Author

Should we also bump the K8s version used in the tests to get coverage for this issue?

I'm working on that now. That will require a few more changes. I'll update this review when I have this figured out.

- Bump versions of Grafana and InfluxDB Helm charts. The latest version
  of Grafana suppresses creation of the PodSecurityPolicy resource if it
  is not available.
- Replace requirements.lock with Chart.lock. Chart.lock is what gets
  generated when dependencies are defined using Chart.yaml. There is no
  requirements.yaml, so requirements.lock should not exist.
- Update versions of dependencies installed in install_deps.sh.
- Update install_deps.sh to use latest minikube and to not use
  --vm-driver, which apparently does not (or no longer) accepts --cpus
  and --memory.
- Use large VM instance, which has 4 cores.
- Update Golang libraries. All dependencies are inherited through the
  nuodb-helm-charts test library, so go.mod was updated to bump the
  nuodb-helm-charts version and all other libraries there were deleted,
  and then 'go mod tidy' was invoked to update go.mod and go.sum.
@sivanov-nuodb
Copy link
Contributor

@adriansuarez Thanks for figuring out the K8s version bump! Looks good to me.

@adriansuarez adriansuarez force-pushed the asuarez/fix-psp-deprecation branch from ed6b2e6 to 23ed10a Compare January 19, 2023 13:58
@adriansuarez adriansuarez merged commit 4353ac7 into master Jan 19, 2023
@adriansuarez adriansuarez deleted the asuarez/fix-psp-deprecation branch January 19, 2023 18:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants