Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Implement SeekableIterator #54

Closed
paales opened this issue Sep 23, 2013 · 1 comment
Closed

Implement SeekableIterator #54

paales opened this issue Sep 23, 2013 · 1 comment

Comments

@paales
Copy link

paales commented Sep 23, 2013

See documentation: http://nl3.php.net/SeekableIterator

Our current use case requires the implementation of SeekableIterator. I'm willing to create a pull request for this. Any suggestions on implementing it?
pilsetnieks added a commit that referenced this issue Apr 18, 2015
@pilsetnieks
v.0.5.10.
493ccd4 
- Implemented SeekableIterator. Thanks to
[paales](https://github.com/paales) for suggestion ([Issue
#54](#54) and [Pull
request #55](#55)).
- Fixed a bug in CSV and ODS reading where reading position 0 multiple
times in a row would result in internal pointer being advanced and
reading the next line. (E.g. reading row #0 three times would result in
rows #0, #1, and #2.). This could have happened on multiple calls to
`current()` while in #0 position, or calls to `seek(0)` and `current()`.
@pilsetnieks
Copy link
Member

This was implemented in v.0.5.10. (493ccd4). Thanks for your suggestion and for your pull request.

ChrisJasperse pushed a commit to ho-nl-fork/spreadsheet-reader that referenced this issue Apr 4, 2016
@pilsetnieks @ChrisJasperse
v.0.5.10.
a982e9c 
- Implemented SeekableIterator. Thanks to
[paales](https://github.com/paales) for suggestion ([Issue
nuovo#54](nuovo#54) and [Pull
request nuovo#55](nuovo#55)).
- Fixed a bug in CSV and ODS reading where reading position 0 multiple
times in a row would result in internal pointer being advanced and
reading the next line. (E.g. reading row #0 three times would result in
rows #0, nuovo#1, and nuovo#2.). This could have happened on multiple calls to
`current()` while in #0 position, or calls to `seek(0)` and `current()`.
xpullox pushed a commit to xpullox/GsheetReader that referenced this issue Jun 24, 2021
v.0.5.10.
543af84 
- Implemented SeekableIterator. Thanks to
[paales](https://github.com/paales) for suggestion ([Issue
#54](nuovo/spreadsheet-reader#54) and [Pull
request #55](nuovo/spreadsheet-reader#55)).
- Fixed a bug in CSV and ODS reading where reading position 0 multiple
times in a row would result in internal pointer being advanced and
reading the next line. (E.g. reading row #0 three times would result in
rows #0, #1, and #2.). This could have happened on multiple calls to
`current()` while in #0 position, or calls to `seek(0)` and `current()`.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pilsetnieks @paales