You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm using the amp-module on a project and deploying with Vercel. In this case I know the production url, but I need to also test in preview deployments with dynamically generated base url's. I expect that the origin as empty string ('') should make this work:
Why is this condition checking if origin is truthy?
The same condition does not apply for appending the amphtml meta.
The text was updated successfully, but these errors were encountered:
jongeyer
changed the title
Origin with empty string is causing canonical links not be appended
Origin with empty string is causing canonical meta not be appended on AMP pages
Sep 29, 2020
I'm using the amp-module on a project and deploying with Vercel. In this case I know the production url, but I need to also test in preview deployments with dynamically generated base url's. I expect that the origin as empty string ('') should make this work:
Expected result:
Actual result:
The logic for this is in plugin.js:
amp-module/lib/amp/plugin.js
Line 108 in 45dfc3e
Why is this condition checking if
origin
is truthy?The same condition does not apply for appending the amphtml meta.
The text was updated successfully, but these errors were encountered: