Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(route-alis): preserve route previous aliases #91

Merged
merged 3 commits into from
Dec 6, 2019

Conversation

j1gs4w
Copy link
Contributor

@j1gs4w j1gs4w commented Dec 3, 2019

Instead of replacing the alias of the route, add an additional alias.
In case other modules create alias or other custom implementations use alias for routes too.

@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #91 into master will decrease coverage by 0.23%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage   68.58%   68.35%   -0.24%     
==========================================
  Files           4        4              
  Lines         156      158       +2     
  Branches       41       42       +1     
==========================================
+ Hits          107      108       +1     
- Misses         36       37       +1     
  Partials       13       13
Impacted Files Coverage Δ
lib/module.js 73.33% <66.66%> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d43019...14ee965. Read the comment docs.

@farnabaz farnabaz changed the title fix: add route alias to array instead of overwriting it fix(route-alis): preserve route previous aliases Dec 6, 2019
@farnabaz farnabaz merged commit 91f3c80 into nuxt-community:master Dec 6, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants