Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(route-alis): preserve route previous aliases #91

Merged
merged 3 commits into from
Dec 6, 2019
Merged

fix(route-alis): preserve route previous aliases #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef30e7f
fix: add route alias to array instead of overwriting it
j1gs4w Dec 3, 2019
40da3e6
fix: eslint errors
j1gs4w Dec 3, 2019
14ee965
fix: module test because alias is now an array
j1gs4w Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,14 @@ function processRoutes () {
for (const route of routes) {
route.meta = route.meta || {}
route.alias = route.alias || []
if (typeof route.alias === 'string') {
route.alias = [route.alias]
}

if (route.path === '/amp' || route.path.indexOf('/amp/') === 0) {
route.meta.amp = true
} else {
route.alias = '/amp' + route.path
route.alias.push('/amp' + route.path)
}
}
})
Expand Down
2 changes: 1 addition & 1 deletion test/module.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe('Generates routes', () => {

test('Routes should be correctly localized', () => {
routes.forEach((route) => {
expect(route.alias).toEqual(`/amp${route.path}`)
expect(route.alias).toEqual([`/amp${route.path}`])
})
})
})
Expand Down