-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Broken server side request with cookies in 5.12.2 #411
Broken server side request with cookies in 5.12.2 #411
Comments
Broken in nuxt/auth as well nuxt-community/auth-module#809 |
+1 |
1 similar comment
+1 |
Is it connected with #428 ? Will it fix the issue? |
Was anyone able to find a workaround? I tried downgrading to 5.12.1... no luck. I made sure axios 0.19.2 was the only version installed. |
Also reported in nuxt-community/auth-module#884 and nuxt-community/auth-module#891 |
Hi. I made PR #452 for fix but still need a reproduction. Seems headers passing from client, are properly proxified to API inside asyncData. Would be nice if can help to make reproduction because otherwise cannot fix... |
@pi0 Let me know if you need anything |
Thanks @msonowal that would be helpful i will try. Yet to fix issue in axios-module, we need bare minimum reproduction without depending on auth module. Taking above diff into account, must suspicious change in axios that broken auth, was axios/axios#1845 which if in auth module, we try to set cookie headers to |
I have just added a minimal reproducer #452 (review) |
Thanks for your great work! |
Thank you so much @pi0. I've already tested and pushed this change into production. Can confirm it has fixed a lot of strange issues we were having. |
Same here, after updating to the latest version (5.12.5), auth module issues from SSR are now fixed |
After upgrading from 5.12.1 to 5.12.2 a server side axios request seems like does not send the original request cookies.
proxyHeaders
is tuned on and it seems to work so I think it is a breaking change in axios itself. 5.12.1 used axios 0.19.2 but 5.12.2 uses axios 0.20.0 and it has a lot of changes axios/axios@v0.19.2...v0.20.0The text was updated successfully, but these errors were encountered: