Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: consistent composer instance properties across scopes #3324

Conversation

BobbieGoede
Copy link
Collaborator

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #3295

The properties on a composer instance changed when using a locale scope, I'm not sure if this was always the case or perhaps this was originally intended to better match legacy vue-i18n type/usage πŸ€”

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede self-assigned this Jan 23, 2025
Copy link

pkg-pr-new bot commented Jan 23, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@nuxtjs/i18n@3324

commit: af4f31a

@BobbieGoede BobbieGoede requested a review from kazupon January 23, 2025 18:26
@BobbieGoede
Copy link
Collaborator Author

After some investigation, this was likely a regression I introduced when integrating vue-i18n-routing and misunderstanding some of the extend structure, I can't reproduce the inconsistency using 8.0.0.

@BobbieGoede BobbieGoede merged commit ab6e533 into nuxt-modules:main Jan 23, 2025
10 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read properties of undefined (reading 'filter')
1 participant