Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(types): use const type parameter for QueryBuilder.only #2546

Merged
merged 2 commits into from
Feb 19, 2024
Merged

fix(types): use const type parameter for QueryBuilder.only #2546

merged 2 commits into from
Feb 19, 2024

Conversation

thunfisch987
Copy link
Contributor

@thunfisch987 thunfisch987 commented Feb 7, 2024

πŸ”— Linked issue

#2545

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #2545
This PR enables having better types when using the .only() function and uses the const type parameter feature that was introduced in Typescript 5.0

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Member

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@farnabaz farnabaz merged commit 7966323 into nuxt:main Feb 19, 2024
2 checks passed
@thunfisch987
Copy link
Contributor Author

I noticed this could probably also be done for .without(), but i didn't try it yet

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use const type Parameter for QueryBuilder.only() to not lose typing
2 participants