Configurable Server Middleware Path #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds middlewarePath default as '/_loading' - uses options.middlewarePath for the path of the middleware that is pushed onto the nuxt serverMiddleware stack
|
I'm late to this party as I'm just trying to get the _loading stuff working with a nuxt app that has multiple "base" paths so can't use the router base like usual. One question - any reason for adding the new 'middlewarePath' option rather than using baseURLAlt? baseURLAlt appears to have been added to control the client-side URI but currently doesn't change the middleware URI so it makes sense to use the same in both places but, as I said, I'm new to this so I've possibly missed something obvious 😄 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_loadingPath for Module Middleware #85pushed onto the nuxt serverMiddleware stack
Very much open to feedback on this as I am new to the codebase.