Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(deps): update @nuxtjs/color-mode to v3.4.2 #1922

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

biering
Copy link

@biering biering commented Jun 27, 2024

πŸ”— Linked issue

❓ Type of change

  • update @nuxtjs/color-mode to v3.4.2
  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

Description

I'm getting this error when running vitest in an test file with the nuxt context (from @nuxtjs/test-utils):

TypeError: helper.removeColorScheme is not a function
 ❯ node_modules/@nuxtjs/color-mode/dist/runtime/plugin.client.js:84:12
     82|   }
     83|   nuxtApp.hook("app:mounted", () => {
     84|     if (colorMode.unknown) {
       |            ^
     85|       colorMode.preference = helper.preference;
     86|       colorMode.value = helper.value;
 ❯ callWithErrorHandling node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:196:19
 ❯ callWithAsyncErrorHandling node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:203:17
 ❯ job node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:6047:9
 ❯ callWithErrorHandling node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:196:33
 ❯ flushJobs node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:408:9

This error should be resolved with the new version of @nuxtjs/color-mode.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@biering biering changed the title feat(@nuxtjs/color-mode): update @nuxtjs/color-mode to v3.4.2 fix(@nuxtjs/color-mode): update @nuxtjs/color-mode to v3.4.2 Jun 27, 2024
@benjamincanac benjamincanac changed the title fix(@nuxtjs/color-mode): update @nuxtjs/color-mode to v3.4.2 chore(deps): update @nuxtjs/color-mode to v3.4.2 Jun 27, 2024
@benjamincanac benjamincanac merged commit cb36094 into nuxt:dev Jun 27, 2024
2 checks passed
binhtranhuu pushed a commit to binhtranhuu/nuxt-ui that referenced this pull request Jul 28, 2024
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants