fix: do not expose token in public runtime config (#41)

* fix: do not expose token in public runtime config * fix: remove formatting change * refactor: avoid setting token in first place
nuxtlabs · Apr 11, 2023 · 5490c43 · 5490c43
1 parent 140314f
commit 5490c43
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/module.ts b/src/module.ts
@@ -69,7 +69,6 @@ export default defineNuxtModule<ModuleOptions>({
       owner: options.owner || process.env.GITHUB_OWNER,
       branch: options.branch || process.env.GITHUB_BRANCH,
       repo: options.repo || process.env.GITHUB_REPO,
-      token: options.token || process.env.GITHUB_TOKEN,
       disableCache: options.disableCache,
       parseContents: options.parseContents,
       maxContributors: options.maxContributors
@@ -79,7 +78,9 @@ export default defineNuxtModule<ModuleOptions>({
     // @ts-ignore
     nuxt.options.runtimeConfig.public.github = defu(nuxt.options.runtimeConfig.public.github, config)
     // @ts-ignore
-    nuxt.options.runtimeConfig.github = defu(nuxt.options.runtimeConfig.github, config)
+    nuxt.options.runtimeConfig.github = defu(nuxt.options.runtimeConfig.github, {
+      token: options.token || process.env.GITHUB_TOKEN
+    }, config)
 
     // Autolink issue/PR/commit links using `remark-github` plugin
     if (options.remarkPlugin) {