callback support & fix border in cursor relative #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workaround used here is to not focus the popup window and create the border And then focus the window if needed (enter options)
A closure is saved with all informations (win_id, callback) which is then reinvoked on <CR> press. Also closes the popup.
|
@jbyuki I saw that you archived contextmenu (which I had planned to replace my quickui.vim context menu with) in favor of this. Looking forward to your changes either here or at https://github.com/mjlbach/neovim-ui/ |
Merged
|
My bad on this -- this just feel through the cracks. I merged in #18 (would have merged here but there was conflict). |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @tjdevries,
Awesome that an effort is made to bring vim popup to Neovim.
I needed them (especially popup_menu) for another project.
This adds callbacks and also (maybe not sure?) fix borders when the popup has cursor relative positioning.
If the PR is accepted, I can burry my personal project contextmenu.nvim on it because it basically is identical.
Also, can I help out with the project (adds other options maybe?). Thanks.