fix(#2862): windows path replaces backslashes with forward slashes #2903
Conversation
There was a problem hiding this comment.
Many thanks for your contribution, this looks reasonable.
It looks like all changes are hidden behind the appropriate OS feature flag, thank you.
nvim-tree developers don't have access to or expertise with windows, hence can't test this.
Please be prepared to quickly resolve any issues that may arise from this change. nvim-tree developers will have no option but to roll it back.
alex-courtis
changed the title
There was a problem hiding this comment.
This slash change is quite far-reaching and may result in difficulties for various configurations.
Please verify this change on the variants of windows:
- WSL
- powershell
- nvim-qt
Cygwin / msys2 would be great, however I believe their setup is difficult and there are few users, so I'm happy to take a risk.
- Please resolve the luals check failures. Setting up lua language server will assist you.
|
I verified the file-opening tasks on all three variants, and everything works fine on my end。 |
|
Many thanks for your contribution @dogeggz |
#2962) * Revert "fix(#2862): windows path replaces backslashes with forward slashes (#2903)" This reverts commit 45a93d9. * fix the case when '()' and '[]' are both in file path * remove debug messages * remove unnecessary comments * add is_windows feature flag when normalizing path * add is_windows flag for filename change * Revert "add is_windows flag for filename change" This reverts commit ada77cb. --------- Co-authored-by: Alexander Courtis <alex@courtis.org>
Fix #2862
Changes:
\with/in file paths for Windows.Note: