Support --install option on sourcing nvm.sh
#602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…less the shell supports passing options upon sourcing.
ljharb
force-pushed
the
install_on_source
branch
from
1183946 to
9a4e906
Compare
ljharb
added a commit
that referenced
this pull request
Dec 26, 2014
Support `--install` option on sourcing `nvm.sh`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #545.
Note that per http://unix.stackexchange.com/questions/5024/passing-a-variable-to-a-bash-script-when-sourcing-it-in-another-bash-script ,
dashandsh(and possibly other shells) do not support passing arguments to a script when sourcing - thenvm_supports_source_optionsmethod determines support for this, and the same method is used to bail out of the tests so that they don't fail ondashandsh. Yay for progressive enhancement :-)