This repository was archived by the owner on Mar 17, 2021. It is now read-only.
Implement read & delete by UID as per Grafana depreciating #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jleeh, sorry for the delay getting to this. I know there's no existing tests for the dashboards API methods (before my time maintaining this repo), but would you mind adding a new |
|
I would be interested to see this PR merged. |
|
Grafana 5 released on 1 Mar 2018. I really think it is time to support the uid field. @mlclmj Can we just merge this PR please ? Im already working on some tests for the dashboard api. PR is coming soon. |
|
See PR #31 (dashboard tests). As soon as this PR is merged, i will extend the dashboard tests. |
matthiasng
approved these changes
Dec 26, 2019
mlclmj
approved these changes
Jan 25, 2020
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the Grafana docs, the get & delete API calls by slug are now deprecated:
https://grafana.com/docs/http_api/dashboard/#deprecated-resources
Updated this client to include the new endpoints, as for me it was causing issues with the Terraform Grafana provider which depends on this library.
Since the endpoints return the same schema, I've just converted the existing methods to accept a URL rather than just a slug.
Can't see any specific tests for these endpoints.