Batch kernels for forward pass of Preprocessing #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssian-rasterization into mlsys/batched_preprocess
…s_gaussians function.
…ssian-rasterization into mlsys/batched_preprocess
…er in __init__.py
…of math.tan in test_batched_gaussian_rasterizer_batch_processing function
…hed inputs in __init__.py
…asterizer_batch_processing functions in rasterization_tests.py
…asterizer_batch_processing functions in rasterization_tests.py
…hed inputs in __init__.py
…ao/diff-gaussian-rasterization into mlsys/batched_preprocess
…asterizer_batch_processing functions in rasterization_tests.py
…asterizer_batch_processing functions in rasterization_tests.py
…asterizer_batch_processing functions in rasterization_tests.py
… non-matching values
… non-matching values
…of batched_raster_settings
…nd result_idx instead of only idx.
prapti19
approved these changes
Apr 29, 2024
TarzanZhao
reviewed
May 11, 2024
TarzanZhao
reviewed
May 11, 2024
| elapsed_time_ms = start_event.elapsed_time(end_event) | ||
| print(f"Time taken by test_batched_gaussian_rasterizer_batch_processing: {elapsed_time_ms:.4f} ms") | ||
|
|
||
| # TODO: make the below work |
There was a problem hiding this comment.
This should work
for means2D in batched_means2D:
means2D.retain_grad()
TarzanZhao
reviewed
May 11, 2024
TarzanZhao
approved these changes
May 11, 2024
TarzanZhao
reviewed
May 11, 2024
| viewpoint_camera.image_width = 512 | ||
| viewpoint_camera.world_view_transform = torch.eye(4).cuda() | ||
| viewpoint_camera.full_proj_transform = torch.eye(4).cuda() | ||
| viewpoint_camera.camera_center = torch.zeros(3).cuda() |
There was a problem hiding this comment.
Let us change torch.zeros to be non-zero values and test it in tomorrow meeting.
There was a problem hiding this comment.
Fix bug for non zero camera centers and test for non identity view transforms
There was a problem hiding this comment.
Tested for these. Will check in those with the backward kernel PR #3
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
preprocess_gaussians_batchedGaussianRasterizerBatchesResults
Tests ran on V100
Time taken by test_batched_gaussian_rasterizer: 81.2411 ms
Time taken by test_batched_gaussian_rasterizer_batch_processing: 33.5708 ms