Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

(feat) make tilde_matrix (skew-symmetric matrix) more idiomatic #173

Merged
merged 1 commit into from
Jun 24, 2023
Merged

(feat) make tilde_matrix (skew-symmetric matrix) more idiomatic #173

merged 1 commit into from
Jun 24, 2023

Conversation

ThibFrgsGmz
Copy link
Contributor

Some improvements we could make to make the code more idiomatic in Rust.

  • Use direct indexing to access vector elements rather than using tuples.
  • Improved documentation to explain what the function does and what it returns.

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage: 88.23% and project coverage change: +0.04 🎉

Comparison is base (63b78f1) 66.70% compared to head (949cf0d) 66.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
+ Coverage   66.70%   66.75%   +0.04%     
==========================================
  Files         127      127              
  Lines       32623    32629       +6     
==========================================
+ Hits        21762    21781      +19     
+ Misses      10861    10848      -13     
Impacted Files Coverage Δ
src/utils.rs 66.41% <88.23%> (+2.06%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChristopherRabotin ChristopherRabotin merged commit 657eb6e into nyx-space:master Jun 24, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants