Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support pickling of a number of important structures to Python #216

Merged

Conversation

ChristopherRabotin
Copy link
Member

@ChristopherRabotin ChristopherRabotin commented Aug 18, 2023

Effects

One can now pickle the following data:

  • TrkConfig
  • FltResid
  • GaussMarkov
  • GroundStation
  • Spacecraft
  • SRPConfig
  • DragConfig
    The following structures can now be loaded from YAML read by Python but not exported:
  • OrbitEstimate
  • SpacecraftDynamics

Moreover, the == in Python is now correctly supported wherever it was incorrect set up.

  • More testing is needed before merging this

If this is a new feature or a bug fix ...

  • Yes, the branch I'm proposing to merge is called issue-xyz where xyz is the number of the issue.

If this change adds or modifies a validation case

  • No.

Copy link
Member Author

@ChristopherRabotin ChristopherRabotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review approved, still needs more testing

@github-actions
Copy link

github-actions bot commented Aug 18, 2023

Visit the preview URL for this PR (updated for commit 91c2f35):

https://nyx-rustdoc--pr216-212-expose-configrep-n1ogapke.web.app

(expires Mon, 28 Aug 2023 03:22:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d8e2a55934352d850c15d11866c39eb2d2e029be

@ChristopherRabotin ChristopherRabotin force-pushed the 212-expose-configrepr-capabilities-in-nyx-python-api branch from d23ba56 to 91c2f35 Compare August 21, 2023 03:19
@ChristopherRabotin ChristopherRabotin merged commit c000659 into master Aug 21, 2023
@ChristopherRabotin ChristopherRabotin deleted the 212-expose-configrepr-capabilities-in-nyx-python-api branch August 21, 2023 04:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant