-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support pickling of a number of important structures to Python #216
Merged
ChristopherRabotin
merged 10 commits into
master
from
212-expose-configrepr-capabilities-in-nyx-python-api
Aug 21, 2023
Merged
Support pickling of a number of important structures to Python #216
ChristopherRabotin
merged 10 commits into
master
from
212-expose-configrepr-capabilities-in-nyx-python-api
Aug 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only works for named items, but it's a start!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self review approved, still needs more testing
Visit the preview URL for this PR (updated for commit 91c2f35): https://nyx-rustdoc--pr216-212-expose-configrep-n1ogapke.web.app (expires Mon, 28 Aug 2023 03:22:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d8e2a55934352d850c15d11866c39eb2d2e029be |
ChristopherRabotin
force-pushed
the
212-expose-configrepr-capabilities-in-nyx-python-api
branch
from
August 21, 2023 03:19
d23ba56
to
91c2f35
Compare
ChristopherRabotin
deleted the
212-expose-configrepr-capabilities-in-nyx-python-api
branch
August 21, 2023 04:45
7 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effects
One can now pickle the following data:
The following structures can now be loaded from YAML read by Python but not exported:
Moreover, the
==
in Python is now correctly supported wherever it was incorrect set up.If this is a new feature or a bug fix ...
issue-xyz
wherexyz
is the number of the issue.If this change adds or modifies a validation case