Updated Keyboard Inputs #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced the code to use the new KeyboardEvent.key property to determine what key is pressed. Primary reason was to enable the Numeric Keypad + and - keys to work just like the main keyboard + and -. Maintained previous properties for backwards compatibility with older browsers.
|
Big fan of your library here! I've used it in an image viewing site for several years now. This week I added a custom button to the footer toolbar, and also updated the package to the latest version. While testing, I found that the + and - keys on the numeric keypad were not registering for the associated image action, so I updated that block of the JS and also made the KeyboardEvent.key property the default value, since keyCode is now depreciated. Using "key" also solved the issue of which "+" key was pressed. This is the first time I've forked a public repo and raised a possible change, so please let me know if I screwed the process up at all. :-) Thanks! John |
|
Please don't modify the dist files, you should modify the |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced the code to use the new KeyboardEvent.key property to determine what key is pressed. Primary reason was to enable the Numeric Keypad + and - keys to work just like the main keyboard + and -. Maintained previous properties for backwards compatibility with older browsers.