Resolve clippy warnings #1201
Merged
Resolve clippy warnings #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o2sh
reviewed
Nov 2, 2023
o2sh
reviewed
Nov 2, 2023
o2sh
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Thanks a lot for taking care of the last clippy warnings @spenserblack
Co-authored-by: Ossama Hjaji <ossama-hjaji@live.fr>
spenserblack
force-pushed
the
chore/clippy-warnings
branch
from
dc60ab7 to
891f6fa
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes unnecessary references (not raised by clippy, but fixed with
cargo clippy --fix)and simplifies the return type signatures.