Generate new initiatorname from scratch (Fixes: #14) #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dupondje
force-pushed
the
fix_initiatorname
branch
from
e2dcdde to
074d81a
Compare
michalskrivanek
requested changes
Nov 24, 2022
dupondje
force-pushed
the
fix_initiatorname
branch
from
074d81a to
d73a410
Compare
|
weird. let me try another PR... |
|
#15 worked ok...hm |
michalskrivanek
force-pushed
the
fix_initiatorname
branch
from
d73a410 to
197d2c6
Compare
|
@lveyde any idea why it fails? |
dupondje
force-pushed
the
fix_initiatorname
branch
from
197d2c6 to
385f0d1
Compare
|
Missed this one :) |
|
aaah, thanks!:) |
michalskrivanek
approved these changes
Nov 25, 2022
michalskrivanek
force-pushed
the
fix_initiatorname
branch
from
385f0d1 to
bfd069b
Compare
lveyde
requested changes
Nov 27, 2022
lveyde
reviewed
Nov 27, 2022
dupondje
force-pushed
the
fix_initiatorname
branch
from
bfd069b to
a128728
Compare
lveyde
reviewed
Nov 28, 2022
lveyde
approved these changes
Nov 28, 2022
sandrobonazzola
force-pushed
the
fix_initiatorname
branch
from
a128728 to
b05cbe3
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the el9 packages don't build an initiatorname by default, we should not depend/use the file in factory anymore, but just generate the string ourselves.
Fixes: #14