Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Disable execution of CreateUserSession from GWT code #914

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

mwperina
Copy link
Member

CreateUserSesssion should be executed only as a part of login flow, so
explicitly disable execution from GWT code.

Signed-off-by: Martin Perina mperina@redhat.com

Copy link
Member

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwperina
Copy link
Member Author

/ost

@mwperina
Copy link
Member Author

/ost basic-suite-master el9stream

@michalskrivanek
Copy link
Member

(it won't pass all the way, but el9stream should get all the way till UI tests, IIRC)

@mwperina
Copy link
Member Author

/ost basic-suite-master el9stream

CreateUserSesssion should be executed only as a part of login flow, so
explicitly disable execution from GWT code.

Signed-off-by: Martin Perina <mperina@redhat.com>
@michalskrivanek
Copy link
Member

/ost basic-suite-master el9stream

1 similar comment
@michalskrivanek
Copy link
Member

/ost basic-suite-master el9stream

@mwperina
Copy link
Member Author

OST passed on CS9, merging

@mwperina mwperina merged commit 08daf9d into oVirt:master Jan 31, 2024
4 checks passed
@mwperina mwperina deleted the ovirt-auth-bypass branch January 31, 2024 07:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants