[RHELC-297] Fix the format of message about unavailable kernel modules. #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In oamg#469, one of the cleanups ended up calling `"\n".join()` on a list of kernel modules twice. The first time changes the list into a string with each entry separated by a newline but the second time changes the string into another string with each chatacter separated by a newline. Fixed that by removing the second `str.join()`. This also refactors away a call to `map()` and use of `lambda`. In modern python, any uses of `map()` or `filter()` can be replaced with either a generator expression or list comprehension. Related to oamg#469
for more information, see https://pre-commit.ci
Codecov ReportBase: 93.35% // Head: 93.35% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
=======================================
Coverage 93.35% 93.35%
=======================================
Files 22 22
Lines 3145 3145
Branches 558 558
=======================================
Hits 2936 2936
Misses 147 147
Partials 62 62
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
abadger
changed the title
r0x0d
approved these changes
Nov 4, 2022
danmyway
approved these changes
Nov 7, 2022
r0x0d
changed the title
hosekadam
pushed a commit
to hosekadam/convert2rhel
that referenced
this pull request
Nov 11, 2022
…s. (oamg#651) * Fix the format of message about unavailable kernel modules. In oamg#469, one of the cleanups ended up calling `"\n".join()` on a list of kernel modules twice. The first time changes the list into a string with each entry separated by a newline but the second time changes the string into another string with each chatacter separated by a newline. Fixed that by removing the second `str.join()`. This also refactors away a call to `map()` and use of `lambda`. In modern python, any uses of `map()` or `filter()` can be replaced with either a generator expression or list comprehension. Related to oamg#469 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Merged
abadger
added a commit
to Andrew-ang9/convert2rhel
that referenced
this pull request
Dec 7, 2022
…s. (oamg#651) * Fix the format of message about unavailable kernel modules. In oamg#469, one of the cleanups ended up calling `"\n".join()` on a list of kernel modules twice. The first time changes the list into a string with each entry separated by a newline but the second time changes the string into another string with each chatacter separated by a newline. Fixed that by removing the second `str.join()`. This also refactors away a call to `map()` and use of `lambda`. In modern python, any uses of `map()` or `filter()` can be replaced with either a generator expression or list comprehension. Related to oamg#469 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Venefilyn
pushed a commit
that referenced
this pull request
Jun 19, 2023
…s. (#651) * Fix the format of message about unavailable kernel modules. In #469, one of the cleanups ended up calling `"\n".join()` on a list of kernel modules twice. The first time changes the list into a string with each entry separated by a newline but the second time changes the string into another string with each chatacter separated by a newline. Fixed that by removing the second `str.join()`. This also refactors away a call to `map()` and use of `lambda`. In modern python, any uses of `map()` or `filter()` can be replaced with either a generator expression or list comprehension. Related to #469 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #469, one of the cleanups ended up calling
"\n".join()on a list of kernel modules twice. The first time changes the list into a string with each entry separated by a newline but the second time changes the string into another string with each chatacter separated by a newline. Fixed that by removing the secondstr.join().This also refactors away a call to
map()and use oflambda. In modern python, any uses ofmap()orfilter()can be replaced with either a generator expression or list comprehension.Related to #469
Jira Issue: RHELC-297
Checklist
[RHELC-]is part of the PR titleRelease Pending