Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[ML-151] enable Summarizer with OAP #144

Merged
merged 15 commits into from
Nov 29, 2021
Merged

[ML-151] enable Summarizer with OAP #144

merged 15 commits into from
Nov 29, 2021

Conversation

minmingzhu
Copy link
Collaborator

  1. enable Summarizer CPU and GPU with one API
  2. add Summarizer example

@minmingzhu
1. enable Summarizer with one API
02be033 
2. add Summarizer example

Signed-off-by: minmingzhu <minming.zhu@intel.com>
@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?
https://github.com/oap-project/oap-mllib/issues

Then could you also rename pull request title and commit log in the following format?

[ML-${ISSUES_ID}] ${detailed message}

See also:

xwu99
xwu99 requested changes Nov 22, 2021
View reviewed changes
Copy link
Collaborator

@xwu99 xwu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls rebase to master as there has been some large refactor.

mllib-dal/src/main/native/SummarizerDALImpl.cpp Outdated Show resolved Hide resolved
mllib-dal/src/spark-3.1.1/main/scala/org/apache/spark/mllib/stat/Statistics.scala Outdated Show resolved Hide resolved
xwu99 and others added 7 commits November 24, 2021 21:06
@xwu99 @minmingzhu
[Core] Refactor and support multiple Spark versions in single JAR (#141)
35cec08 
* add prepare-shims-codebase

* Add NaiveBayes skeleton, to be revised.

* Add NaiveBayes for multi-version

* move namespaces

* update namespaces

* Add PCA shims

* NaiveBayes, KMeans, PCA ready

* Add ALS shims

* Add Shim trait

* Fix default paramMap

* Add LinearRegression 3.1.1 & 3.1.2

* update prepare-shims-codebase

* Update pom to 3.2.0, Add LinearRegression 3.2.0

* Update CI

* Update CI

* update permission

* nit

* nit

* update ci

* update CI

* nit

* update ci

* nit

* nit

* nit

* fix building native change phase process-resources to generate-resources

* update CI

* update README

* nit

* Fix spark-submit -v bug for 3.2.0 by removing -v

* update apt-get -y -q

* update README
@minmingzhu
Merge remote-tracking branch 'origin/summarizer' into summarizer
b07d220 
Conflicts:
	mllib-dal/src/main/native/build-jni.sh
@minmingzhu
1. add Summarizer example and CI
9b33201 
2. refactor Low-Order Moments
3. fix comments

Signed-off-by: minmingzhu <minming.zhu@intel.com>
@minmingzhu
1. add Summarizer example and CI
86bc2b2 
2. refactor Low-Order Moments

Signed-off-by: minmingzhu <minming.zhu@intel.com>
@minmingzhu
Merge remote-tracking branch 'origin/summarizer' into summarizer
fa6b303 
Conflicts:
	mllib-dal/src/main/native/build-jni.sh
@minmingzhu
1. fix CI error.
0b24ebe 
2. add unit test
3. modify README

Signed-off-by: minmingzhu <minming.zhu@intel.com>
@minmingzhu
1. change directory name
68d41de 
Signed-off-by: minmingzhu <minming.zhu@intel.com>
minmingzhu and others added 5 commits November 26, 2021 14:11
@minmingzhu
1. check codestyle
bca35e1 
2. add numericTable1xNToVector function and instead of numericTableToOldMatrix in SummarizerDALImpl.scala

Signed-off-by: minmingzhu <minming.zhu@intel.com>
@minmingzhu
Update OneDAL.scala
71d37a3
@minmingzhu
Update MultivariateStatisticalDALSummary.scala
e061d7a
@minmingzhu
1. remove isOAPEnable function
4f2c5b0 
Signed-off-by: minmingzhu <minming.zhu@intel.com>
@minmingzhu
1. update README and SummaryStatisticsExample.scala
c44e1b7 
Signed-off-by: minmingzhu <minming.zhu@intel.com>
@minmingzhu
Copy link
Collaborator Author

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/oap-mllib/issues

Then could you also rename pull request title and commit log in the following format?

[ML-${ISSUES_ID}] ${detailed message}

See also:

@minmingzhu minmingzhu closed this Nov 29, 2021
@minmingzhu minmingzhu reopened this Nov 29, 2021
@minmingzhu minmingzhu changed the title enable Summarizer with OAP [ML-151] enable Summarizer with OAP Nov 29, 2021
@github-actions
Copy link

#151

minmingzhu added 2 commits November 29, 2021 11:24
@minmingzhu
1. modify permission
eb6c012 
Signed-off-by: minmingzhu <minming.zhu@intel.com>
@minmingzhu
1. update run.sh
d971124 
Signed-off-by: minmingzhu <minming.zhu@intel.com>
@xwu99 xwu99 merged commit a11723c into oap-project:master Nov 29, 2021
@xwu99
Copy link
Collaborator

xwu99 commented Nov 29, 2021

@minmingzhu thanks for your work. Merged!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@xwu99 xwu99 xwu99 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minmingzhu @xwu99