fix memory leak #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lganzzzo
reviewed
Dec 22, 2021
src/oatpp-zlib/Processor.cpp
Outdated
| @@ -63,6 +63,11 @@ DeflateEncoder::DeflateEncoder(v_buff_size bufferSize, bool gzip, v_int32 compre | |||
|
|
|||
| } | |||
|
|
|||
| DeflateEncoder::~DeflateEncoder() { | |||
| v_int32 res = deflateEnd(&m_zStream); | |||
| OATPP_ASSERT(res == Z_OK); | |||
There was a problem hiding this comment.
Let's remove the assert.
Let's just log the error instead:
OATPP_LOGE("[oatpp::zlib::DeflateEncoder::~DeflateEncoder()]", "Error. Failed call to 'deflateEnd()'.")There was a problem hiding this comment.
Thanks for your suggestion. I have modified the code.
The same problem was found in the decoder and fixed.
Please review, thank you!
|
I ran the test program with Valgrind and found no memory leak now. |
|
Merged! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix this bug:
oatpp/oatpp#445