Skip to content

Commit

Permalink
Properly silence cargo output unless --verbose. (#903)
Browse files Browse the repository at this point in the history
Before this, output was always silenced since the check was inverted.
It would only be unsilenced if the log level was less verbose than INFO,
which is the opposite of what we want.
  • Loading branch information
obi1kenobi authored Sep 2, 2024
1 parent 9ba903c commit 9b31c7e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,9 @@ impl Check {
}

pub fn check_release(&self, config: &mut GlobalConfig) -> anyhow::Result<Report> {
let rustdoc_cmd = RustdocCommand::new().deps(false).silence(config.is_info());
let rustdoc_cmd = RustdocCommand::new()
.deps(false)
.silence(!config.is_verbose());

// If both the current and baseline rustdoc are given explicitly as a file path,
// we don't need to use the installed rustc, and this check can be skipped.
Expand Down

0 comments on commit 9b31c7e

Please # to comment.