Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Consider either testing that lint file names match their id fields, or removing the field entirely. #735

Closed
obi1kenobi opened this issue Apr 3, 2024 · 0 comments · Fixed by #783
Closed

Consider either testing that lint file names match their id fields, or removing the field entirely. #735

obi1kenobi opened this issue Apr 3, 2024 · 0 comments · Fixed by #783
Labels
C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.

Comments

@obi1kenobi
Copy link
Owner

Sometimes new lint contributions accidentally fail to set the id field of new lints correctly. #734 fixed one such issue.

We want a field like id available on the deserialized value for purposes of naming the lint and reporting failures.

We should either have a test that makes sure each lint file name matches its id field, or remove the field from the file and somehow otherwise populate it during deserialization.
@obi1kenobi obi1kenobi added C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue. labels Apr 3, 2024
@obi1kenobi obi1kenobi mentioned this issue Apr 3, 2024
Merged
@pksunkara pksunkara mentioned this issue Apr 10, 2024
Closed
jw013 added a commit to jw013/cargo-semver-checks that referenced this issue May 27, 2024
@jw013
fix: obi1kenobi#735
322c1d0 
Remove id field from lint .ron's and set id based
on file name passed to add_lints! macro instead.
jw013 added a commit to jw013/cargo-semver-checks that referenced this issue May 27, 2024
@jw013
fix: obi1kenobi#735
46475ec 
Remove id field from lint .ron's and set id based
on file name passed to add_lints! macro instead.
@jw013 jw013 mentioned this issue May 27, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.
Projects
None yet
Milestone
No milestone
1 participant
@obi1kenobi