Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support linting breaking changes in manifests & add feature_missing lint #1007

Merged
merged 13 commits into from
Dec 1, 2024

Conversation

obi1kenobi
Copy link
Owner

@obi1kenobi obi1kenobi commented Nov 30, 2024

Add support for linting of package manifests, allowing us to scan for breaking changes there as well.

For example, deleting a feature is a major breaking change. As of this PR, we can detect and report that:

--- failure feature_missing: package feature removed or renamed ---

Description:
A feature has been removed from this package's Cargo.toml. This will break downstream crates which enable that feature.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#cargo-feature-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.37.0/src/lints/feature_missing.ron

Failed in:
  feature going_missing in the package's Cargo.toml
  feature rand in the package's Cargo.toml

     Summary semver requires new major version: 1 major and 0 minor checks failed

Completes the first checkbox of the 2024H2 Rust Project Goal on cargo-semver-checks: rust-lang/rust-project-goals#104

Unblocks the lints specified in #48.

@obi1kenobi obi1kenobi changed the title First draft: Linting manifests for breaking changes Support linting manifests for breaking changes & add feature_missing lint Nov 30, 2024
@obi1kenobi obi1kenobi changed the title Support linting manifests for breaking changes & add feature_missing lint Support linting breaking changes in manifests & add feature_missing lint Nov 30, 2024
@obi1kenobi obi1kenobi marked this pull request as ready for review November 30, 2024 23:54
@obi1kenobi obi1kenobi mentioned this pull request Dec 1, 2024
5 tasks
@obi1kenobi obi1kenobi merged commit e6bed4d into main Dec 1, 2024
33 checks passed
@obi1kenobi obi1kenobi deleted the patched_adapter branch December 1, 2024 00:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant